expression: simple expression IsTruthWithNull/IsTruthWithoutNull with CAST

[hawkingrei]

What problem does this PR solve?

Issue Number: close #61062

close #51359

Problem Summary:

What changed and how does it work?

IsTruthWithNull/IsTruthWithoutNull with cast(cast(xxx)) ( IsTruthWithNull(cast(cast(xxx)))) can be transfer into IsTruthWithNull/IsTruthWithoutNull(xxx).

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No need to test

  • I checked and no code files have been changed.

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

expression: simple expression IsTruthWithNull/IsTruthWithoutNull with CAST

简化带 CAST 的 IsTruthWithNull/IsTruthWithoutNull 表达式

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from hawkingrei and additionally assign windtalker for approval(Please ensuring that each of them provides their approval before proceeding). For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• pkg/expression/OWNERS
• pkg/planner/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.4729%. Comparing base (2503d50) to head (3dc6f01).
Report is 12 commits behind head on master.

Additional details and impacted files

@@               Coverage Diff                @@
##             master     #61076        +/-   ##
================================================
+ Coverage   73.1498%   73.4729%   +0.3230%     
================================================
  Files          1724       1724                
  Lines        477078     478816      +1738     
================================================
+ Hits         348982     351800      +2818     
+ Misses       106697     105602      -1095     
- Partials      21399      21414        +15     

Flag	Coverage Δ
integration	42.5656% <ø> (?)
unit	72.3819% <ø> (+0.0244%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	52.7804% <ø> (ø)
parser	∅ <ø> (∅)
br	47.1585% <ø> (-0.3939%)	⬇️

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[TheoristCoder]

Dear Developers, Kindly inquire that if this bug is also related to this root case? #60127

[hawkingrei]

Dear Developers, Kindly inquire that if this bug is also related to this root case? #60127

I take a look at this problem. it is not the same as the root cause.

[windtalker]

The convert is too aggressive, istrue(cast(xxx as xxx)) is not always equal to istrue(xxx)
For example:

mysql> select istrue_with_null('0.1');
+-------------------------+
| istrue_with_null('0.1') |
+-------------------------+
|                       1 |
+-------------------------+
1 row in set (0.01 sec)

mysql> select istrue_with_null(cast('0.1' as signed));
+-----------------------------------------+
| istrue_with_null(cast('0.1' as signed)) |
+-----------------------------------------+
|                                       0 |
+-----------------------------------------+
1 row in set, 1 warning (0.00 sec)

[hawkingrei]

/hold