Skip to content

server: replace instead of truncate encoded result #61080

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 19, 2025

Conversation

xhebox
Copy link
Contributor

@xhebox xhebox commented May 12, 2025

What problem does this PR solve?

Issue Number: close #61085

Problem Summary: Change behavior when convert result.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Fix bug that character_set_results will truncate instead of replace on error char

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 12, 2025
Copy link

tiprow bot commented May 12, 2025

Hi @xhebox. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@xhebox
Copy link
Contributor Author

xhebox commented May 12, 2025

/ok-to-test

@ti-chi-bot ti-chi-bot bot added the ok-to-test Indicates a PR is ready to be tested. label May 12, 2025
@xhebox
Copy link
Contributor Author

xhebox commented May 12, 2025

/test all

Copy link

codecov bot commented May 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.7290%. Comparing base (c71ebaf) to head (c80d808).
Report is 34 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #61080        +/-   ##
================================================
+ Coverage   73.1307%   73.7290%   +0.5982%     
================================================
  Files          1724       1724                
  Lines        477081     485681      +8600     
================================================
+ Hits         348893     358088      +9195     
+ Misses       106761     106069       -692     
- Partials      21427      21524        +97     
Flag Coverage Δ
integration 42.6020% <100.0000%> (?)
unit 72.6323% <100.0000%> (+0.2668%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.7804% <ø> (ø)
parser ∅ <ø> (∅)
br 46.9379% <ø> (-0.6091%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ti-chi-bot ti-chi-bot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. labels May 12, 2025
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels May 15, 2025
@xhebox xhebox changed the title [WIP] server: replace instead of truncate encoded result [WIP] server: replace instead of truncate encoded result | tidb-test=pr/2517 May 19, 2025
@pingcap pingcap deleted a comment from ti-chi-bot bot May 19, 2025
@pingcap pingcap deleted a comment from tiprow bot May 19, 2025
@pingcap pingcap deleted a comment from tiprow bot May 19, 2025
@xhebox
Copy link
Contributor Author

xhebox commented May 19, 2025

/test mysql-test

Copy link

tiprow bot commented May 19, 2025

@xhebox: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test fast_test_tiprow
  • /test tidb_parser_test

Use /test all to run all jobs.

In response to this:

/test mysql-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@xhebox xhebox changed the title [WIP] server: replace instead of truncate encoded result | tidb-test=pr/2517 server: replace instead of truncate encoded result | tidb-test=pr/2517 May 19, 2025
@ti-chi-bot ti-chi-bot bot removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/needs-tests-checked labels May 19, 2025
@ti-chi-bot ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 19, 2025
@xhebox xhebox changed the title server: replace instead of truncate encoded result | tidb-test=pr/2517 server: replace instead of truncate encoded result May 19, 2025
Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

ti-chi-bot bot commented May 19, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bb7133, tangenta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels May 19, 2025
Copy link

ti-chi-bot bot commented May 19, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-05-15 03:24:57.296859776 +0000 UTC m=+588363.444821019: ☑️ agreed by tangenta.
  • 2025-05-19 06:07:03.747421788 +0000 UTC m=+351990.003319175: ☑️ agreed by bb7133.

@ti-chi-bot ti-chi-bot bot merged commit d5dcbdf into pingcap:master May 19, 2025
24 checks passed
@xhebox xhebox deleted the fix3 branch May 19, 2025 07:47
@ti-chi-bot ti-chi-bot bot added needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. labels May 20, 2025
ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request May 20, 2025
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #61192.
But this PR has conflicts, please resolve them!

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request May 20, 2025
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #61193.
But this PR has conflicts, please resolve them!

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #61194.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.1: #61195.

xhebox added a commit to ti-chi-bot/tidb that referenced this pull request May 21, 2025
xhebox added a commit to ti-chi-bot/tidb that referenced this pull request May 21, 2025
xhebox added a commit to ti-chi-bot/tidb that referenced this pull request May 21, 2025
xhebox added a commit to ti-chi-bot/tidb that referenced this pull request May 21, 2025
xhebox added a commit to ti-chi-bot/tidb that referenced this pull request May 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. ok-to-test Indicates a PR is ready to be tested. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

should replace instead of truncation for result charset
4 participants