Skip to content

[DNM]*: demo for no_null_index and use index(tiflash) on release 8.5 #61123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 10 commits into
base: release-8.5
Choose a base branch
from

Conversation

YangKeao
Copy link
Member

What problem does this PR solve?

Issue Number: close #xxx

Problem Summary:

ref #61044 and #60010

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. component/dumpling This is related to Dumpling of TiDB. sig/planner SIG: Planner size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels May 15, 2025
@YangKeao YangKeao changed the base branch from master to release-8.5 May 15, 2025 05:25
Copy link

ti-chi-bot bot commented May 15, 2025

This cherry pick PR is for a release branch and has not yet been approved by triage owners.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick:

  1. It must be approved by the approvers firstly.
  2. AFTER it has been approved by approvers, please wait for the cherry-pick merging approval from triage owners.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

tiprow bot commented May 15, 2025

@YangKeao: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
fast_test_tiprow cc5c074 link true /test fast_test_tiprow
tidb_parser_test cc5c074 link true /test tidb_parser_test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@YangKeao
Copy link
Member Author

/retest

@pingcap pingcap deleted a comment from ti-chi-bot bot May 15, 2025
@YangKeao YangKeao force-pushed the cherry-pick-no-null-index-to-8.5 branch from cc5c074 to 570e24f Compare May 15, 2025 05:33
Copy link

ti-chi-bot bot commented May 15, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign bornchanger, d3hunter, rustin170506, tangenta, yudongusa for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented May 15, 2025

Codecov Report

Attention: Patch coverage is 72.80702% with 62 lines in your changes missing coverage. Please review.

Please upload report for BASE (release-8.5@b992ca8). Learn more about missing BASE report.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-8.5     #61123   +/-   ##
================================================
  Coverage               ?   77.1922%           
================================================
  Files                  ?       1642           
  Lines                  ?     450346           
  Branches               ?          0           
================================================
  Hits                   ?     347632           
  Misses                 ?      81407           
  Partials               ?      21307           
Flag Coverage Δ
integration 50.3495% <71.4912%> (?)
unit 72.6495% <38.1578%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9278% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 63.1155% <0.0000%> (?)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@YangKeao YangKeao force-pushed the cherry-pick-no-null-index-to-8.5 branch 2 times, most recently from 3c30e6c to 9c75df3 Compare May 15, 2025 06:18
Signed-off-by: Yang Keao <[email protected]>
@YangKeao YangKeao force-pushed the cherry-pick-no-null-index-to-8.5 branch from 9c75df3 to 98f1886 Compare May 15, 2025 06:26
@YangKeao YangKeao force-pushed the cherry-pick-no-null-index-to-8.5 branch 3 times, most recently from 63bf2a4 to e9e7439 Compare May 15, 2025 07:51
@YangKeao YangKeao force-pushed the cherry-pick-no-null-index-to-8.5 branch from e9e7439 to c849edf Compare May 15, 2025 08:21
Copy link

ti-chi-bot bot commented May 15, 2025

@YangKeao: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-integration-e2e-test cc5c074 link true /test pull-integration-e2e-test
pull-integration-ddl-test cc5c074 link true /test pull-integration-ddl-test
pull-mysql-client-test cc5c074 link true /test pull-mysql-client-test
pull-lightning-integration-test cc5c074 link true /test pull-lightning-integration-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@YangKeao
Copy link
Member Author

pkg/executor/test/seqtest exceeds time limit 🤦 . Let me check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/dumpling This is related to Dumpling of TiDB. do-not-merge/cherry-pick-not-approved do-not-merge/needs-linked-issue do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants