Skip to content

#67299

Closed
0xPoe wants to merge 1 commit into
pingcap:masterfrom
0xPoe:poe-patch-sample-based-ndv
Closed

#67299
0xPoe wants to merge 1 commit into
pingcap:masterfrom
0xPoe:poe-patch-sample-based-ndv

Conversation

@0xPoe
Copy link
Copy Markdown
Member

@0xPoe 0xPoe commented Mar 25, 2026

@0xPoe 0xPoe added the skip-issue-check Indicates that a PR no need to check linked issue. label Mar 25, 2026
@ti-chi-bot ti-chi-bot Bot added release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Mar 25, 2026
@0xPoe 0xPoe changed the title docs: add sample based NDV design WIP: docs: add sample based NDV design Mar 25, 2026
@ti-chi-bot ti-chi-bot Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 25, 2026
coderabbitai[bot]

This comment was marked as spam.

coderabbitai[bot]

This comment was marked as spam.

coderabbitai[bot]

This comment was marked as spam.

coderabbitai[bot]

This comment was marked as spam.

coderabbitai[bot]

This comment was marked as spam.

@hawkingrei
Copy link
Copy Markdown
Member

/ok-to-test

@ti-chi-bot ti-chi-bot Bot added the ok-to-test Indicates a PR is ready to be tested. label Mar 27, 2026
@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot Bot commented Mar 28, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign hanfei1991 for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@0xPoe 0xPoe force-pushed the poe-patch-sample-based-ndv branch 4 times, most recently from 4d75866 to 2fee495 Compare March 30, 2026 08:08
@0xPoe 0xPoe changed the title WIP: docs: add sample based NDV design docs: add sample based NDV design Mar 30, 2026
@ti-chi-bot ti-chi-bot Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 30, 2026
@0xPoe 0xPoe force-pushed the poe-patch-sample-based-ndv branch 6 times, most recently from 10ee558 to 81f448e Compare March 30, 2026 08:37
@0xPoe 0xPoe force-pushed the poe-patch-sample-based-ndv branch 4 times, most recently from a7fce2e to 462eaf7 Compare April 1, 2026 16:07
@0xPoe 0xPoe force-pushed the poe-patch-sample-based-ndv branch from 893389d to 04ed0e3 Compare April 1, 2026 18:29
@ti-chi-bot ti-chi-bot Bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. do-not-merge/needs-tests-checked and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Apr 1, 2026
@0xPoe 0xPoe changed the title docs: add sample based NDV design Apr 1, 2026
@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot Bot commented Apr 1, 2026

[FORMAT CHECKER NOTIFICATION]

Notice: To remove the do-not-merge/invalid-title label, please follow title format, for example pkg [, pkg2, pkg3]: what is changed or *: what is changed.

📖 For more info, you can check the "Contribute Code" section in the development guide.


Notice: To remove the do-not-merge/needs-tests-checked label, please finished the tests then check the finished items in description.

For example:

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

📖 For more info, you can check the "Contribute Code" section in the development guide.

@pingcap pingcap deleted a comment from pantheon-ai Bot Apr 1, 2026
@pingcap pingcap deleted a comment from coderabbitai Bot Apr 1, 2026
@pingcap pingcap deleted a comment from coderabbitai Bot Apr 1, 2026
@pingcap pingcap deleted a comment from coderabbitai Bot Apr 1, 2026
@pingcap pingcap deleted a comment from coderabbitai Bot Apr 1, 2026
@pingcap pingcap deleted a comment from coderabbitai Bot Apr 1, 2026
@pingcap pingcap deleted a comment from coderabbitai Bot Apr 1, 2026
@pingcap pingcap deleted a comment from coderabbitai Bot Apr 1, 2026
@tiprow
Copy link
Copy Markdown

tiprow Bot commented Apr 1, 2026

@0xPoe: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
fast_test_tiprow 04ed0e3 link true /test fast_test_tiprow
tidb_parser_test 04ed0e3 link true /test tidb_parser_test

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@0xPoe 0xPoe closed this Apr 1, 2026
@0xPoe 0xPoe deleted the poe-patch-sample-based-ndv branch April 1, 2026 18:32
@pingcap pingcap deleted a comment from coderabbitai Bot Apr 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/invalid-title do-not-merge/needs-tests-checked ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. skip-issue-check Indicates that a PR no need to check linked issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants