Skip to content

*: update client-go to the latest version#68058

Closed
lcwangchao wants to merge 0 commit into
pingcap:masterfrom
lcwangchao:update_go_mod
Closed

*: update client-go to the latest version#68058
lcwangchao wants to merge 0 commit into
pingcap:masterfrom
lcwangchao:update_go_mod

Conversation

@lcwangchao

@lcwangchao lcwangchao commented Apr 27, 2026

Copy link
Copy Markdown
Collaborator

What problem does this PR solve?

Issue Number: close #68057

What changed and how does it work?

updated client-go to the latest version

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.
      tests have been added in client-go

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

- The default value of config `ru-scale` is set to `2.10`

Summary by CodeRabbit

  • Chores
    • Updated the TiKV client library dependency to a newer pinned revision across build/config files.
  • Documentation
    • Adjusted the TiKV client RU v2 scaling factor in the example configuration to a new value.

@ti-chi-bot ti-chi-bot Bot added do-not-merge/needs-triage-completed release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/needs-linked-issue size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 27, 2026
@coderabbitai

coderabbitai Bot commented Apr 27, 2026

Copy link
Copy Markdown
📝 Walkthrough

Walkthrough

Updated the pinned github.com/tikv/client-go/v2 dependency (Go module pseudo-version and Bazel fetch metadata) and changed the TiKV client RU v2 scaling factor in the example config.

Changes

Cohort / File(s) Summary
Bazel dependency metadata
DEPS.bzl
Updated go_repository(...) for github.com/tikv/client-go/v2: new sha256, updated strip_prefix, and revised archive urls to match the new revision.
Go module dependency
go.mod
Bumped github.com/tikv/client-go/v2 pseudo-version to v2.0.8-0.20260423085316-fce9638195b3.
Example configuration
pkg/config/config.toml.example
Changed [tikv-client.ru-v2] ru-scale from 1.40 to 2.10.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested labels

ok-to-test

Suggested reviewers

  • cfzjywxk
  • YuJuncen
  • lhy1024

Poem

🐰 Hopped in the tree of deps today,
Bumped client-go, rolled hashes away,
RU scale tweaked, configs anew,
Bazel and Go now sing on cue,
A joyful little rabbit says "Yay!"

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title "*: update client-go to the latest version" clearly and concisely summarizes the main change in the PR, which is updating the client-go dependency.
Linked Issues check ✅ Passed The PR successfully addresses the linked issue #68057 by updating client-go to the latest version and synchronizing the RU v2 scaling factor configuration with upstream changes.
Out of Scope Changes check ✅ Passed All changes are scoped to the client-go dependency update: DEPS.bzl pinning, go.mod version, and RU v2 configuration alignment, with no unrelated modifications present.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description check ✅ Passed PR description follows the template structure with issue number and change summary, though the 'What changed and how does it work?' section is minimal and lacks technical depth about the config change.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@ti-chi-bot ti-chi-bot Bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 27, 2026
@codecov

codecov Bot commented Apr 27, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.1194%. Comparing base (49c7713) to head (39c25c5).
⚠️ Report is 1 commits behind head on master.

⚠️ Current head 39c25c5 differs from pull request most recent head ce68c53

Please upload reports for the commit ce68c53 to get more accurate results.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #68058        +/-   ##
================================================
- Coverage   77.7596%   77.1194%   -0.6402%     
================================================
  Files          1990       1972        -18     
  Lines        551591     552273       +682     
================================================
- Hits         428915     425910      -3005     
- Misses       121756     126327      +4571     
+ Partials        920         36       -884     
Flag Coverage Δ
integration 41.3495% <ø> (+1.5476%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 60.4888% <ø> (ø)
parser ∅ <ø> (∅)
br 50.0597% <ø> (-13.0338%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@lcwangchao

Copy link
Copy Markdown
Collaborator Author

/retest

2 similar comments
@lcwangchao

Copy link
Copy Markdown
Collaborator Author

/retest

@lcwangchao

Copy link
Copy Markdown
Collaborator Author

/retest

@ti-chi-bot ti-chi-bot Bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Apr 28, 2026
@ti-chi-bot ti-chi-bot Bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Apr 28, 2026
@ti-chi-bot

ti-chi-bot Bot commented Apr 28, 2026

Copy link
Copy Markdown

[LGTM Timeline notifier]

Timeline:

  • 2026-04-28 04:41:10.824410082 +0000 UTC m=+2659276.029770139: ☑️ agreed by ekexium.

@ti-chi-bot

ti-chi-bot Bot commented Apr 28, 2026

Copy link
Copy Markdown

@wfxr: adding LGTM is restricted to approvers and reviewers in OWNERS files.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@lcwangchao lcwangchao closed this Apr 29, 2026
@ti-chi-bot ti-chi-bot Bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 29, 2026
@ti-chi-bot

ti-chi-bot Bot commented Apr 29, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ekexium, wfxr

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-1-more-lgtm Indicates a PR needs 1 more LGTM. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

update client-go to the latest version

3 participants