-
Notifications
You must be signed in to change notification settings - Fork 298
sink(ticdc): waiting the asynchronous ddl to synchronize #12123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Skipping CI for Draft Pull Request. |
|
/test pull-cdc-integration-mysql-test |
hongyunyan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Please complete the "Check List" part of this PR description. Specifically, remove the items that you didn't do and the redundant items (No code). |
|
Please conduct a manual test to ensure there are no performance issues when there are thousands of tables. I'm concerned about the execution time of the query: |
I test it with v9.0.0-beta.1.pre-nightly version, and you could find more information in pingcap/tidb#55748 |
|
/retest |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: asddongmen, hongyunyan The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
|
/test pull-engine-integration-test |
|
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <[email protected]>
What problem does this PR solve?
Issue Number: close #12114 close #12128
What is changed and how it works?
When a DDL operation takes a long time, the connection may be lost, even though the DDL is actually executed. Instead of throwing a failure state, we can query the downstream and wait for the DDL to complete.
Notice:
Check List
Tests
Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note