-
Notifications
You must be signed in to change notification settings - Fork 298
ticdc: MySQL sink dispatcher routing #12435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
a-cong
wants to merge
17
commits into
pingcap:release-8.5
Choose a base branch
from
a-cong:sink-dispatcher-routing
base: release-8.5
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+4,012
−54
Open
Changes from 3 commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
13c8b51
support schema routing for mysql sink in ticdc
a-cong 2312089
add dispatcher-based sink routing with SchemaRule/TableRule support
a-cong 676be0e
move dispatcher validation
a-cong 986c4ff
address comments
a-cong d201848
address comments, add integration test
a-cong 44cf56b
Merge branch 'release-8.5' into sink-dispatcher-routing
a-cong 34e60aa
fix: replace logutil.ZapRedactString with zap.String for upstream com…
a-cong 6c070f2
fix: format imports in processor.go
a-cong d418240
test: add t.Parallel() to all test subtests for tparallel linter
a-cong d444af7
chore: regenerate msgp code for TableName with TargetSchema/TargetTab…
a-cong c8dd505
fix test config
a-cong 9d7bb01
fix: create new TableInfo objects
a-cong 7feb4d0
test: add integration test for redo log replay with schema routing
a-cong 1cf984e
fix: use failpoint pattern for redo log schema routing test
a-cong fe61fe8
use WrapError for error handling
a-cong 769181d
test: add more ddls/dmls to integration test
a-cong f94f22b
fix: apply sink routing to new table ID after TRUNCATE TABLE
a-cong File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The comment for
DispatchRuleis outdated and doesn't reflect the extended functionality. It says "represents partition rule for a table" but it now also handles schema/table routing for MySQL sinks. This should be updated to match the comprehensive comment inpkg/config/sink.gowhich correctly describes both MQ (topic/partition) and MySQL (schema/table routing) use cases.