mounter(ticdc): fix truncate table cause mounter failed (#12431) #12445
Conversation
ti-chi-bot
added
lgtm
release-note
|
This cherry pick PR is for a release branch and has not yet been approved by triage owners. To merge this cherry pick:
DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Summary of ChangesHello @ti-chi-bot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request resolves a critical bug in the TiCDC mounter that previously led to changefeed failures when a partitioned table was truncated. The core change involves enhancing the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request fixes a bug where truncating a partition table could cause the changefeed to fail. The core change is in truncateTable to correctly handle partition tables by recording their partition IDs in truncatedTables. The test cases are also updated to reflect this change.
My main feedback is about a potential panic in the new logic when a partitioned table is truncated into a non-partitioned table. I've provided a suggestion to make the code more robust against this scenario.
| newPi := tbInfo.GetPartitionInfo() | ||
| oldPi := old.GetPartitionInfo() | ||
| newPartitionIDMap := make(map[int64]struct{}, len(newPi.NewPartitionIDs)) | ||
| for _, partition := range newPi.Definitions { | ||
| newPartitionIDMap[partition.ID] = struct{}{} | ||
| } | ||
| for _, partition := range oldPi.Definitions { | ||
| if _, ok := newPartitionIDMap[partition.ID]; !ok { | ||
| s.truncatedTables.ReplaceOrInsert(newVersionedID(partition.ID, tag)) | ||
| } | ||
| } |
There was a problem hiding this comment.
The current implementation has a potential for a panic. If a partitioned table is truncated into a non-partitioned table, tbInfo.GetPartitionInfo() will return nil, making newPi a nil pointer. Subsequently, accessing newPi.NewPartitionIDs on line 797 will cause a panic.
To prevent this, you should add a nil check for newPi. If newPi is nil, it implies all old partitions have been removed, and we should add all partition IDs from oldPi to truncatedTables.
Additionally, for initializing newPartitionIDMap, it's more direct and robust to use len(newPi.Definitions) for the capacity, as the map is populated by iterating over newPi.Definitions.
oldPi := old.GetPartitionInfo()
if newPi := tbInfo.GetPartitionInfo(); newPi != nil {
newPartitionIDMap := make(map[int64]struct{}, len(newPi.Definitions))
for _, partition := range newPi.Definitions {
newPartitionIDMap[partition.ID] = struct{}{}
}
for _, partition := range oldPi.Definitions {
if _, ok := newPartitionIDMap[partition.ID]; !ok {
s.truncatedTables.ReplaceOrInsert(newVersionedID(partition.ID, tag))
}
}
} else {
// The new table is not a partition table, so all old partitions are truncated.
for _, partition := range oldPi.Definitions {
s.truncatedTables.ReplaceOrInsert(newVersionedID(partition.ID, tag))
}
}
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: wk989898 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@ti-chi-bot: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
2 participants
This is an automated cherry-pick of #12431
What problem does this PR solve?
Issue Number: close #12430
What is changed and how it works?
If the table is a partition table, we have to record the partition table id when executing the truncate table ddl.
Check List
Tests
Before this PR:
After this PR:
Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note