test: update date formats and expected results in MySQL tests #12480

cryo-zd · 2026-01-04T08:33:47Z

What problem does this PR solve?

Issue Number: close #12479

What is changed and how it works?

Check List

Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
No code

Questions

Will it cause performance regression or break compatibility?

Do you need to update user documentation, design documentation or monitoring documentation?

Release note

Please refer to [Release Notes Language Style Guide](https://pingcap.github.io/tidb-dev-guide/contribute-to-tidb/release-notes-style-guide.html) to write a quality release note.

If you don't think this PR needs a release note then fill it with `None`.

ti-chi-bot · 2026-01-04T08:33:57Z

Hi @cryo-zd. Thanks for your PR.

I'm waiting for a pingcap member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

ti-chi-bot · 2026-01-04T08:33:57Z

Welcome @cryo-zd!

It looks like this is your first PR to pingcap/tiflow 🎉.

I'm the bot to help you request reviewers, add labels and more, See available commands.

We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to pingcap/tiflow. 😃

pingcap-cla-assistant · 2026-01-04T08:33:59Z

All committers have signed the CLA.

gemini-code-assist · 2026-01-04T08:34:02Z

Summary of Changes

Hello @cryo-zd, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on enhancing the reliability and accuracy of MySQL integration tests, specifically those related to date and time format functions. By updating expected test results and introducing a mechanism to ensure consistent result ordering, the changes aim to prevent test flakiness and provide a more robust testing suite for date and time operations.

Highlights

Test Result Updates: Updated the expected output for various GET_FORMAT function calls related to TIME, DATETIME, and TIMESTAMP types in the MySQL integration tests.
Result Ordering Consistency: Introduced the --sorted_result directive in a test case to ensure consistent ordering of results, particularly for queries involving the TIME datatype, which helps prevent flaky test failures due to varying output order.
MySQL Compatibility: Refined expected results for LEAST function calls and comparisons involving TIME values, improving the accuracy of MySQL compatibility tests.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request updates the expected results for MySQL date format tests. The changes correctly update the output for get_format and a LEAST function call that depends on it. Additionally, it makes a test case on the TIME data type deterministic by sorting the results, and updates the expected output accordingly. My review includes a suggestion to improve test cleanup by dropping tables after they are used.

gemini-code-assist · 2026-01-04T08:35:00Z

tests/integration_tests/tidb_mysql_test/t/date_formats.test

+--sorted_result
 SELECT b, b = '121314',
       CASE b WHEN '121314' then 'found' ELSE 'not found' END FROM t8;
 SELECT b, b in ('121314'), b in ('121314', 0) FROM t8;


To ensure proper test cleanup and avoid potential side effects in subsequent tests, it's good practice to drop the tables created for this test case. Consider adding DROP TABLE t6, t7, t8; after these queries.

SELECT b, b in ('121314'), b in ('121314', 0) FROM t8; DROP TABLE t6, t7, t8;

YangKeao · 2026-01-04T08:43:13Z

tests/integration_tests/tidb_mysql_test/t/date_formats.test

+--sorted_result
 SELECT b, b = '121314',
       CASE b WHEN '121314' then 'found' ELSE 'not found' END FROM t8;
 SELECT b, b in ('121314'), b in ('121314', 0) FROM t8;


Should we also add a --sorted_result to this SQL? It seems that its result also changed.

wk989898 · 2026-01-04T09:47:18Z

/ok-to-test

ti-chi-bot · 2026-01-04T09:51:38Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 3AceShowHand, wk989898

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [3AceShowHand,wk989898]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot · 2026-01-04T09:51:41Z

[LGTM Timeline notifier]

Timeline:

2026-01-04 09:04:33.66800722 +0000 UTC m=+520229.486315652: ☑️ agreed by wk989898.
2026-01-04 09:51:40.2596206 +0000 UTC m=+523056.077929042: ☑️ agreed by 3AceShowHand.

wk989898 · 2026-01-04T13:25:40Z

/retest

wk989898 · 2026-01-05T08:04:12Z

/retest

wk989898 · 2026-01-05T09:13:40Z

/retest

wk989898 · 2026-01-05T13:40:31Z

/retest

wk989898 · 2026-01-05T15:14:23Z

/retest

wk989898 · 2026-01-05T16:20:12Z

/retest

wk989898 · 2026-01-05T17:15:11Z

/retest

wk989898 · 2026-01-06T03:44:36Z

/retest

wk989898 · 2026-01-06T09:05:05Z

/retest

wk989898 · 2026-01-06T12:20:13Z

/retest

wk989898 · 2026-01-06T15:16:42Z