refactor(conn): replace dbutil.GetTables with conn.GetTables for cons…

[GMHDBJD]

…istency

What problem does this PR solve?

Issue Number: close #xxx

What is changed and how it works?

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No code

Questions

Will it cause performance regression or break compatibility?

Do you need to update user documentation, design documentation or monitoring documentation?

Release note

Please refer to [Release Notes Language Style Guide](https://pingcap.github.io/tidb-dev-guide/contribute-to-tidb/release-notes-style-guide.html) to write a quality release note.

If you don't think this PR needs a release note then fill it with `None`.

[ti-chi-bot]

[FORMAT CHECKER NOTIFICATION]

Notice: To remove the do-not-merge/needs-linked-issue label, please provide the linked issue number on one line in the PR body, for example: Issue Number: close #123 or Issue Number: ref #456.

_{📖 For more info, you can check the "Contribute Code" section in the development guide.}

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign d3hunter for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• dm/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[gemini-code-assist]

Summary of Changes

Hello @GMHDBJD, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request undertakes a refactoring effort to enhance code consistency by relocating the GetTables utility function. Previously residing in the dbutil package, this function has now been moved to dm/pkg/conn/db.go, centralizing database-related table retrieval logic. All instances where dbutil.GetTables was invoked have been updated to correctly reference the new conn.GetTables function, streamlining dependencies and improving maintainability.

Highlights

• GetTables Function Relocation: The GetTables utility function has been moved from github.com/pingcap/tidb/pkg/util/dbutil to dm/pkg/conn/db.go to centralize database connection-related utilities.
• Dependency Update: Imports and call sites across dm/master/openapi_view.go and dm/pkg/checker/onlineddl.go have been updated to reflect the new location of the GetTables function, now referencing conn.GetTables.
• Code Consistency: This refactoring improves code consistency by consolidating database table retrieval logic within the conn package, reducing reliance on external dbutil for this specific functionality.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request refactors the code to use conn.GetTables instead of dbutil.GetTables, which is a good improvement for code organization. The implementation of the new conn.GetTables function is mostly correct, but I've suggested a couple of minor improvements for consistency and idiomatic Go.

A more critical issue is that the unit tests in dm/pkg/conn/db_test.go and dm/master/openapi_view_test.go appear to be broken by this change. They still mock the old SQL query from dbutil.GetTables (SHOW FULL TABLES ... WHERE ...). Please update the mocked queries to SHOW FULL TABLES IN ... without the WHERE clause to match the new implementation in conn.GetTables.

[gemini-code-assist]

For consistency with the error handling in this package, it's better to return a terror error instead of a raw error created with errors.New. You can use terror.ErrDBUnExpect.Generate for this.

Suggested change

	if len(cols) < 2 {
	return nil, errors.New("SHOW FULL TABLES returned less than 2 columns")
	}
	if len(cols) < 2 {
	return nil, terror.ErrDBUnExpect.Generate("SHOW FULL TABLES returned less than 2 columns")
	}

[gemini-code-assist]

This loop for creating dummy scan arguments can be made more efficient and idiomatic. Instead of declaring a new dummy variable in each iteration, you can allocate space for the columns you want to ignore directly. Using sql.RawBytes is a good practice for this as it can avoid extra allocations.

Suggested change

	var dummy interface{}
	scanArgs[i] = &dummy
	scanArgs[i] = new(sql.RawBytes)

[ti-chi-bot]

@GMHDBJD: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-verify	51906e6	link	true	/test pull-verify
pull-dm-integration-test	51906e6	link	true	/test pull-dm-integration-test

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.