Skip to content

Conversation

@breezewish
Copy link
Member

@breezewish breezewish commented Jan 5, 2026

What problem does this PR solve?

close #xxx

What is changed and how it works?

Playground-ng is a complete refactor of playground, providing same functionality, but:

  • Iterate faster, agents driven
  • More user and agents friendly

Start the playground locally to see what's the improvements:

image

Major features:

  • More user friendly TUI
  • More log friendly output
  • Existing feature is reserved and compatible, including scale-in and scale-out.

Major refactors:

  • Clear separation of components and services

    Components: tidb, tikv, pd, etc (a component can be download from tiup registry)
    Services: pd-tso, pd-api, tikv, tikv-worker, tiflash-wn, etc

  • Better race condition prevention: one event handling goroutine for all

  • Service catalogs to define behaviors

  • Better process lifecycle management

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release notes:

NONE

Signed-off-by: Wish <[email protected]>
Signed-off-by: Wish <[email protected]>
@ti-chi-bot ti-chi-bot bot requested review from kaaaaaaang and srstack January 5, 2026 13:09
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jan 5, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign bb7133 for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jan 5, 2026
@codecov-commenter
Copy link

codecov-commenter commented Jan 5, 2026

Codecov Report

❌ Patch coverage is 55.46024% with 3271 lines in your changes missing coverage. Please review.
✅ Project coverage is 41.45%. Comparing base (ed0fab6) to head (f1acdba).

Files with missing lines Patch % Lines
components/playground-ng/service/dm.go 17.30% 153 Missing ⚠️
components/playground-ng/start.go 54.24% 117 Missing and 34 partials ⚠️
components/playground-ng/boot.go 66.51% 80 Missing and 59 partials ⚠️
components/playground-ng/main.go 69.82% 98 Missing and 36 partials ⚠️
components/playground-ng/command.go 63.61% 76 Missing and 47 partials ⚠️
components/playground-ng/service/binlog.go 18.37% 120 Missing ⚠️
components/playground-ng/artifacts.go 52.44% 87 Missing and 30 partials ⚠️
components/playground-ng/controller.go 60.00% 80 Missing and 32 partials ⚠️
components/playground-ng/service/service.go 54.20% 88 Missing and 21 partials ⚠️
components/playground-ng/proc/dm.go 4.46% 105 Missing and 2 partials ⚠️
... and 65 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2662      +/-   ##
==========================================
+ Coverage   38.51%   41.45%   +2.94%     
==========================================
  Files         360      417      +57     
  Lines       37499    46013    +8514     
==========================================
+ Hits        14439    19072    +4633     
- Misses      21257    24357    +3100     
- Partials     1803     2584     +781     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@breezewish breezewish changed the title playground: Refactor playground-ng: Initial commit Jan 13, 2026
@xhebox xhebox merged commit 0003eee into master Jan 13, 2026
19 of 44 checks passed
@xhebox xhebox deleted the wenxuan/progressbarv2 branch January 13, 2026 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants