Skip to content

Conversation

@JaySon-Huang
Copy link
Contributor

What problem does this PR solve?

When start playground with specified tiflash binary using --tiflash.binpath, tiflash will start using the config that is only for version earlier than v7.1. That is unexpected.

./bin/tiup-playground nightly --mode 'tidb-fts' --tici.binpath /DATA/disk1/jaysonhuang/tici/target/debug/tici-server --s3.endpoint http://10.2.12.79:9000 --s3.bucket ticidefault --tiflash.binpath /DATA/disk1/jaysonhuang/tiflash/cmake-build-debug/dbms/src/Server/tiflash --tag jayson-play-tici

What is changed and how it works?

When start playground with specified tiflash binary, the inst.Version is empty. Usually this case is use for testing or development, start with new mode.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
# Run the command below and check the generated tiflash config
./bin/tiup-playground nightly --mode 'tidb-fts' --tici.binpath /DATA/disk1/jaysonhuang/tici/target/debug/tici-server --s3.endpoint http://10.2.12.79:9000 --s3.bucket ticidefault --tiflash.binpath /DATA/disk1/jaysonhuang/tiflash/cmake-build-debug/dbms/src/Server/tiflash --tag jayson-play-tici
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release notes:

Fixed a bug in playground that caused TiFlash to launch with unexpected configurations when an explicit binary path was specified

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jan 14, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign xhebox for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot requested a review from srstack January 14, 2026 07:10
@ti-chi-bot ti-chi-bot bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 14, 2026
@codecov-commenter
Copy link

codecov-commenter commented Jan 14, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 41.51%. Comparing base (0890ea9) to head (41d09cf).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2670      +/-   ##
==========================================
- Coverage   41.52%   41.51%   -0.01%     
==========================================
  Files         417      417              
  Lines       45579    45580       +1     
==========================================
- Hits        18926    18922       -4     
- Misses      24109    24112       +3     
- Partials     2544     2546       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ti-chi-bot ti-chi-bot bot added the lgtm label Jan 14, 2026
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jan 14, 2026

[LGTM Timeline notifier]

Timeline:

  • 2026-01-14 08:00:13.192786029 +0000 UTC m=+430857.254650940: ☑️ agreed by xhebox.

@xhebox xhebox merged commit 628d4c6 into pingcap:master Jan 14, 2026
12 of 22 checks passed
@JaySon-Huang JaySon-Huang deleted the fix_tiflash_patch_master branch January 14, 2026 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants