cluster: abort force scale-in when PD delete fails#2704
Conversation
Signed-off-by: lhy1024 <admin@liudos.us>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2704 +/- ##
==========================================
- Coverage 42.72% 42.14% -0.58%
==========================================
Files 424 424
Lines 49744 47146 -2598
==========================================
- Hits 21253 19868 -1385
+ Misses 25797 24595 -1202
+ Partials 2694 2683 -11 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Signed-off-by: lhy1024 <admin@liudos.us>
Signed-off-by: lhy1024 <admin@liudos.us>
What problem does this PR solve?
Close #2705
When
tiup cluster scale-in --forcescales in a TiKV instance, TiUP currently ignores errors from deleting the store/member in PD, then continues to stop/destroy the instance and remove it from the topology.If PD rejects the delete-store request, for example because removing the TiKV would make the number of remaining up stores less than
max-replicas, the store remainsUp/Servingin PD while TiUP no longer shows the instance intiup cluster display.What is changed and how it works?
forcequery.scale-in --forcepath, return the PD delete error immediately instead of warning and continuing.PDClient.DelStoredoes not send theforcequery parameter.Check List
Tests
Code changes
Side effects
Related changes
Release notes: