Skip to content

Conversation

@Puppo
Copy link

@Puppo Puppo commented Jan 3, 2026

This PR fix the issue5.test.js file

@Puppo
Copy link
Author

Puppo commented Jan 3, 2026

@jsumners, This PR should fix the issue you asked about here.
I restarted the entire implementation from the master implementation, applied your changes, and used psock.stdout.

BTW, before the test was wrong, Stdin is a writable stream, and we cannot use the pipe.
The issue was that the expect didn't have a check.
This is the issue
wrong

Copy link
Member

@jsumners jsumners left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@jsumners jsumners merged commit 6102dd2 into pinojs:new-major Jan 8, 2026
2 of 7 checks passed
@Puppo Puppo deleted the new-major branch January 8, 2026 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants