fix: use util.getCallSites when able to allow frozen intrinsics #2294
+36
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsumners
reviewed
Sep 29, 2025
jsumners
reviewed
Sep 30, 2025
test/caller.test.js
Outdated
| @@ -0,0 +1,21 @@ | |||
| const { test } = require('tap') | |||
There was a problem hiding this comment.
Suggested change
| const { test } = require('tap') | |
| 'use strict' | |
| const { test } = require('tap') |
Also, please use node:test instead. Tap will be removed with #2299.
You can remove the outer test(). It's unnecessary.
There was a problem hiding this comment.
Sorry for the delay, I've updated the test 👍
CarlOlson
force-pushed
the
fix-frozen-intrinsics
branch
from
12cbb7a to
a8193d8
Compare
jsumners
approved these changes
Oct 11, 2025
|
Tests fail on Windows. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #2071
The examples pass now with
--frozen-intrinsics.