fix: std error serializer should prefer err.name over error.constructor.name #2332
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change updates the default error serializer to use
err.name(if present) instead oferr.constructor.namewhen setting thetypefield.This ensures human-readable error types even when class names are minified in production builds.
Problem
When using frameworks like Next.js (which use the SWC minifier), class names are renamed during build. This causes custom error types to appear as single-letter identifiers in logs.
Example:
Setting
this.name = 'ValidationError'in the constructor partially fixes this, buterr.typeremains incorrect because Pino reads fromerr.constructor.name:The only other workaround is to forcibly override
constructor.name, which is not safe since it’s a read-only property.Solution
Prefer
err.name(if defined) overerr.constructor.namewhen settingtype. I think this change should be made directly in the standard serializer rather than requiring users to provide their own error serializer, since the issue occurs in every Next.js production app that does not opt out of minification.The same change needs to be made in
pino-std-serializers, let me know what you think about this before I go ahead with that.The drawback here is that "type" will simply be "Error" if the user forgets to override
this.name. Feel free to close this PR if you think that is worse than the problem I described here.