chore: replace tap with borp in cov-ui script#2382
Open
lraveri wants to merge 1 commit intopinojs:mainfrom
Open
chore: replace tap with borp in cov-ui script#2382lraveri wants to merge 1 commit intopinojs:mainfrom
lraveri wants to merge 1 commit intopinojs:mainfrom
Conversation
Signed-off-by: Luca Raveri <lucaraveri993@gmail.com>
Member
|
the PR to borp would be perfect, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
I noticed that there’s still a script in package.json relying on tap to generate the HTML coverage report.
At the moment we can generate it with the command I proposed, but it feels like something borp should handle directly. Would it make sense to add an extra flag to borp, something like --coverage-ui, to generate the HTML report as well?
Related question: does it still make sense to rely on borp nowadays, now that Node.js has native TypeScript support and the --experimental-test-coverage flag? Do you see a future migration in that direction?
Happy to help