Add a section that explains the downtime with replica 1#163
Add a section that explains the downtime with replica 1#163gortiz wants to merge 1 commit intopinot-contrib:latestfrom
Conversation
| | bootstrap | false | Rebalances all segments again, **as if adding segments to an empty table**. If this is false, then the rebalance will try to minimize segment movements. | | ||
|
|
||
| ### Rebalance with only 1 replica | ||
| In general, when the table config uses only 1 replica, the downtime may be affected. |
There was a problem hiding this comment.
Just a minor reword if it makes sense.
"The downtime option is not relevant when rebalance is initiated on a table with a replication factor of 1 and there's no further change to the replication factor. In this case, there'll be a downtime during rebalance.
However when the rebalance is initiated for increasing replication (from 1 to > 1), the downtime flag can be used (set to false) to avoid downtime."
There was a problem hiding this comment.
i think with downtime = false and replication = 1 (with no changes to final replication count), the rebalance will itself be blocked. So this would be untrue "In this case, there'll be a downtime during rebalance"
There was a problem hiding this comment.
What do you mean with the rebalance itself will be blocked?
There was a problem hiding this comment.
I've recently found this PR is still open. I'm going to apply the change suggested by Manish. About the suggestion from Neha... do we know the actual behavior? IIRC I didn't actually tested that and the written here is what I inferred seen the code, but I may be wrong.
4 participants
The description that explains the case when replica is 1 wasn't very clear. Specifically, when increasing the number of replicas.
This PR adds a couple of paragraphs to specifically focus on the replica 1 case.