Skip to content

Conversation

@Gundue
Copy link
Contributor

@Gundue Gundue commented Oct 31, 2025

  • Corrected typo in async_monkey_patch_for_pinpoint (was 'asyn_monkey_patch_for_pinpoint')
  • Removed use_starlette_context, updated to use_thread_local_context and use_asyncio_local_context
  • Ensures compatibility with latest pinpoint agent and async context handling

Describe your changes

why we need this pr?

Issue ticket number and link

if it has issues, add them

Checklist before requesting a review

  • I have performed a self-review of my code
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics?
  • Will this be part of a product update? If yes, please write one phrase about this update.

- Corrected typo in async_monkey_patch_for_pinpoint (was 'asyn_monkey_patch_for_pinpoint')
- Removed use_starlette_context, updated to use_thread_local_context and use_asyncio_local_context
- Ensures compatibility with latest pinpoint agent and async context handling
@eeliu
Copy link
Collaborator

eeliu commented Nov 3, 2025

Thanks

Copy link
Collaborator

@eeliu eeliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eeliu eeliu added this pull request to the merge queue Nov 3, 2025
Merged via the queue into pinpoint-apm:dev with commit a63d912 Nov 3, 2025
7 checks passed
@codecov
Copy link

codecov bot commented Nov 3, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.57%. Comparing base (5187cc0) to head (c14c69a).
⚠️ Report is 70 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #731      +/-   ##
==========================================
- Coverage   80.79%   80.57%   -0.23%     
==========================================
  Files          22       22              
  Lines        1536     1539       +3     
  Branches      165      168       +3     
==========================================
- Hits         1241     1240       -1     
- Misses        162      165       +3     
- Partials      133      134       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants