Skip to content

[#369] Extract logger.setRootLogger out of AgentBuilder #370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
feelform merged 1 commit into from
Sep 10, 2025
Merged

[#369] Extract logger.setRootLogger out of AgentBuilder #370

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,12 @@
const { AgentBuilder } = require('./lib/agent-builder')
const AgentInfo = require('./lib/data/dto/agent-info')
const { getConfig } = require('./lib/config')
const { LogBuilder } = require('./lib/utils/log/log-builder')
const logger = require('./lib/utils/log/logger')

const config = getConfig()
logger.setRootLogger(LogBuilder.createDefaultLogBuilder().setConfig(config).build())

const agentInfo = AgentInfo.make(config)
const agent = new AgentBuilder(agentInfo)
.setConfig(config)
Expand Down
2 changes: 0 additions & 2 deletions lib/agent-builder.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@

'use strict'

const { LogBuilder } = require('./utils/log/log-builder')
const logger = require('./utils/log/logger')
const dataSenderFactory = require('./client/data-sender-factory')
const stringMetaService = require('./context/string-meta-service')
Expand Down Expand Up @@ -120,7 +119,6 @@ class AgentBuilder {
if (!this.config) {
this.config = getConfig()
}
logger.setRootLogger(LogBuilder.createDefaultLogBuilder().setConfig(this.config).build())

const agent = new Agent(this.agentInfo, this.config, logger)
if (!this.dataSender) {
Expand Down
15 changes: 5 additions & 10 deletions lib/utils/log/types.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,19 +25,17 @@ export declare interface Appender {
}

export declare class LogBuilder {
constructor(name?: string);
static createDefaultLogBuilder(): LogBuilder;

constructor(name?: string);
build(): Log;
logLevelDebug(): LogBuilder;
logLevelInfo(): LogBuilder;
logLevelWarn(): LogBuilder;
logLevelError(): LogBuilder;
logLevelSilent(): LogBuilder;

addAppender(appender: Appender): LogBuilder;

build(): Log;

static LogLevel: typeof LogLevel;
setConfig(config: { [key: string]: any }): LogBuilder;
}

export declare class Log {
Expand All @@ -53,22 +51,20 @@ export declare interface Logging {
info(...args: any[]): void;
warn(...args: any[]): void;
error(...args: any[]): void;

isDebug(): boolean;
isInfo(): boolean;
}

export declare class Logger implements Logging {

debug(...args: any[]): void;
info(...args: any[]): void;
warn(...args: any[]): void;
error(...args: any[]): void;

isDebug(): boolean;
isInfo(): boolean;

getLogger(log: Log): Logger;
setRootLogger(log: Log): void;
}

export declare class ChildLogger implements Logging {
Expand All @@ -78,7 +74,6 @@ export declare class ChildLogger implements Logging {
info(...args: any[]): void;
warn(...args: any[]): void;
error(...args: any[]): void;

isDebug(): boolean;
isInfo(): boolean;
}
Expand Down