Skip to content

Conversation

@feelform
Copy link
Collaborator

No description provided.

@feelform feelform force-pushed the sql-stats branch 2 times, most recently from 6354a71 to 1571d5b Compare September 18, 2025 13:03
@feelform feelform requested a review from Copilot September 18, 2025 13:21
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces a ConfigurationBuilder for flexible configuration management, replacing the previous singleton-based configuration approach with a more modular and testable design.

  • Implements ConfigBuilder class to replace imperative configuration initialization
  • Updates HTTP status code error handling to support dynamic configuration changes
  • Refactors test files to use destructured imports and improve test reliability

Reviewed Changes

Copilot reviewed 11 out of 15 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
lib/config.js Major refactoring to add ConfigBuilder class and replace singleton pattern
lib/context/trace/span-recorder.js Updates to use new HTTP status code error handling
lib/instrumentation/http/http-status-code-errors-builder.js Adds singleton pattern for HTTP status code error management
index.js Updates to use ConfigBuilder instead of direct getConfig
test/config.test.js Updates to use destructured imports and adds tests for HTTP status code error handling
test/support/agent-singleton-mock.js Updates imports to include clear function
test/client/grpc-fixture.js Updates to use new configuration structure
test/client/grpc-unary-rpc.test.js Updates to use destructured imports
test/agent/env-config.test.js Updates to use destructured imports
test/instrumentation/module/undici.test.js Makes test assertions more dynamic for remote address
test/instrumentation/module/http.test.js Makes test assertions more dynamic for remote address

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@pinpoint-apm pinpoint-apm deleted a comment from Copilot AI Sep 18, 2025
@feelform feelform merged commit c654eaa into pinpoint-apm:master Sep 18, 2025
3 checks passed
@feelform feelform deleted the sql-stats branch September 18, 2025 14:05
@feelform feelform linked an issue Oct 22, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove circular dependency between config and logger

1 participant