Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Nov 14, 2025

The checkstyle GitHub Action was commented out and previously failed with "Resource not accessible by integration" due to missing authentication token.

Changes

  • Uncommented lint step that generates checkstyle XML report via ESLint
  • Uncommented checkstyle upload action that posts violations as PR annotations
  • Added explicit token: ${{ secrets.GITHUB_TOKEN }} parameter to fix authentication error
- name: Upload checkstyle report
  if: matrix.node_version == env.TARGET_COVERAGE_NODE_VERSION
  uses: jwgmeligmeyling/checkstyle-github-action@master
  with:
    path: '**/checkstyle-result.xml'
    token: ${{ secrets.GITHUB_TOKEN }}

The workflow already has required permissions (checks: write, pull-requests: write). The explicit token ensures the action can create check runs with annotations.

Original prompt

This section details on the original issue you should resolve

<issue_title>Support checkstyle</issue_title>
<issue_description>### Issue

Run jwgmeligmeyling/checkstyle-github-action@master
With the provided path, there will be 1 results uploaded
Creating annotations for /home/runner/work/pinpoint-node-agent/pinpoint-node-agent/checkstyle-result.xml
Uploading 31 / 31 annotations to GitHub as Checkstyle with conclusion failure
Error: HttpError: Resource not accessible by integration
```</issue_description>

<agent_instructions>You have to add checkstyle report into Pull requests.</agent_instructions>

## Comments on the Issue (you are @copilot in this section)

<comments>
</comments>


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Copilot AI self-assigned this Nov 14, 2025
uses: jwgmeligmeyling/checkstyle-github-action@master
with:
path: '**/checkstyle-result.xml'
token: ${{ secrets.GITHUB_TOKEN }}
Copy link
Collaborator

@feelform feelform Nov 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have to use secrets.REPO_TOKEN token

Copilot AI changed the title [WIP] Add support for Checkstyle report in PRs Enable checkstyle reporting in CI workflow Nov 14, 2025
Copilot AI requested a review from feelform November 14, 2025 05:31
@feelform
Copy link
Collaborator

feelform commented Nov 14, 2025

LCOV of commit a626eee during CI #1298

Summary coverage rate:
  lines......: 84.4% (3522 of 4173 lines)
  functions..: 82.3% (849 of 1031 functions)
  branches...: 70.6% (1117 of 1583 branches)

Files changed coverage rate: n/a

@feelform feelform marked this pull request as ready for review November 14, 2025 05:41
@feelform feelform merged commit d7a9db6 into master Nov 14, 2025
9 of 10 checks passed
@feelform feelform deleted the copilot/add-checkstyle-report branch November 14, 2025 05:42
@feelform feelform added this to the 1.4 milestone Nov 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support checkstyle

2 participants