Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#11274] record real request path as an annotation, no normalization. #11302

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

[#11274] record real request path as an annotation, no normalization. #11302

wants to merge 4 commits into from

Conversation

yjqg6666
Copy link
Contributor

@yjqg6666 yjqg6666 commented Jul 30, 2024 •
edited
Loading

Fix #11274.

UI v2:
image

image

UI v3:
image

@yjqg6666 yjqg6666 marked this pull request as draft July 30, 2024 02:08
@codecov Codecov
Copy link

codecov bot commented Jul 30, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 55.00000% with 9 lines in your changes missing coverage. Please review.

Project coverage is 36.93%. Comparing base (17a9c88) to head (cc5bb2e).

Files Patch % Lines
...om/navercorp/pinpoint/common/server/bo/SpanBo.java 0.00% 4 Missing ⚠️
...navercorp/pinpoint/web/filter/AcceptUrlFilter.java 62.50% 1 Missing and 2 partials ⚠️
...ansactionlist/TransactionDotMetaDataViewModel.java 0.00% 1 Missing ⚠️
.../transactionlist/TransactionMetaDataViewModel.java 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff            @@
##             master   #11302   +/-   ##
=========================================
  Coverage     36.92%   36.93%           
- Complexity    12077    12084    +7     
=========================================
  Files          4011     4011           
  Lines         98307    98323   +16     
  Branches      10429    10432    +3     
=========================================
+ Hits          36301    36316   +15     
- Misses        59035    59037    +2     
+ Partials       2971     2970    -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yjqg6666 yjqg6666 marked this pull request as ready for review July 30, 2024 09:37
@yjqg6666 yjqg6666 requested a review from emeroad July 30, 2024 09:38
@yjqg6666 yjqg6666 force-pushed the real-request-path-annotation branch from 698ff50 to cc5bb2e Compare August 1, 2024 02:16
@yjqg6666
Copy link
Contributor Author

yjqg6666 commented Aug 1, 2024

Rebased on the current master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emeroad emeroad Awaiting requested review from emeroad

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FR.] record real request path as an annotation, no normalization.
1 participant
@yjqg6666