Skip to content

Conversation

@emeroad
Copy link
Member

@emeroad emeroad commented Dec 3, 2025

This pull request updates how the serviceType field is handled in the UidLinkRowKey class to improve consistency and compatibility with inverted integer storage. The main changes involve inverting the serviceType value during row key creation and restoring it during reading.

Row key encoding/decoding improvements:

  • In the makeRowKey method of UidLinkRowKey.java, the serviceType value is now inverted using IntInverter.invert before storing it in the buffer, ensuring consistent encoding for row keys.
  • In the read method of UidLinkRowKey.java, the serviceType value is restored using IntInverter.restore after reading it from the buffer, ensuring correct decoding of the row key.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request updates the UidLinkRowKey class to invert the serviceType field during row key encoding and decoding, improving consistency with the existing pattern used for timestamp inversion and enhancing data distribution in storage.

  • Inverts serviceType using IntInverter.invert() when encoding the row key
  • Restores serviceType using IntInverter.restore() when decoding the row key
  • Fixes an incorrect inline comment that referenced "serviceUid" instead of "serviceType"

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov
Copy link

codecov bot commented Dec 3, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 33.38%. Comparing base (e643de8) to head (39ef6ef).

Additional details and impacted files
@@             Coverage Diff              @@
##             master   #13163      +/-   ##
============================================
- Coverage     33.39%   33.38%   -0.02%     
+ Complexity    10958    10954       -4     
============================================
  Files          4063     4063              
  Lines         93945    93945              
  Branches       9777     9777              
============================================
- Hits          31375    31362      -13     
- Misses        59893    59906      +13     
  Partials       2677     2677              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant