Skip to content

Conversation

@donghun-cho
Copy link
Contributor

No description provided.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR performs a cleanup refactoring focused on the trace index DAO layer, removing unused code and centralizing application name predicate logic.

Changes:

  • Removed unused ExistMapper class and hasTraceIndex method from TraceIndexDao
  • Centralized application name predicate creation in TraceIndexRowKeyUtils
  • Refactored TraceIndexMetaMapper to use a helper method for predicate testing and improved code organization
  • Optimized buffer allocation from AutomaticBuffer to FixedBuffer with exact size calculation

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
TraceIndexMetaMapper.java Reordered constructor parameters, added helper method for predicate testing, changed method visibility
ExistMapper.java Removed unused mapper class
HbaseTraceIndexDao.java Removed unused hasTraceIndex method, replaced inline predicate builder with centralized version
TraceIndexDao.java Removed unused hasTraceIndex interface method
TraceIndexRowKeyUtils.java Added createApplicationNamePredicate method and APPLICATION_NAME_OFFSET constant, optimized buffer allocation

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov
Copy link

codecov bot commented Jan 15, 2026

Codecov Report

❌ Patch coverage is 55.55556% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 33.18%. Comparing base (a3af982) to head (7b0a598).
⚠️ Report is 13 commits behind head on master.

Files with missing lines Patch % Lines
...t/web/scatter/dao/mapper/TraceIndexMetaMapper.java 28.57% 5 Missing ⚠️
...t/common/server/scatter/TraceIndexRowKeyUtils.java 73.33% 3 Missing and 1 partial ⚠️
...oint/web/scatter/dao/hbase/HbaseTraceIndexDao.java 40.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #13294      +/-   ##
============================================
- Coverage     33.22%   33.18%   -0.04%     
- Complexity    10969    10971       +2     
============================================
  Files          4062     4070       +8     
  Lines         94312    94440     +128     
  Branches       9823     9830       +7     
============================================
+ Hits          31331    31339       +8     
- Misses        60308    60426     +118     
- Partials       2673     2675       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@donghun-cho donghun-cho merged commit 0f3c6c2 into pinpoint-apm:master Jan 16, 2026
4 of 5 checks passed
@donghun-cho donghun-cho deleted the cleanup branch January 16, 2026 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant