Skip to content

Conversation

@emeroad
Copy link
Member

@emeroad emeroad commented Jan 19, 2026

append using start and end indices

This pull request makes a minor optimization to the string formatting logic in the DefaultBindingLogFormatter class. The change improves code readability and efficiency by replacing a substring extraction with a more direct string append operation.

  • Refactored the final string append in the format method of DefaultBindingLogFormatter to use builder.append(query, queryPrev, query.length()) instead of builder.append(query.substring(queryPrev)), which is more efficient and concise.

@emeroad emeroad added this to the 3.1.0 milestone Jan 19, 2026
@codecov
Copy link

codecov bot commented Jan 19, 2026

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 33.18%. Comparing base (d295edd) to head (a08e265).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...int/mybatis/plugin/DefaultBindingLogFormatter.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #13304      +/-   ##
============================================
- Coverage     33.18%   33.18%   -0.01%     
+ Complexity    10974    10973       -1     
============================================
  Files          4070     4070              
  Lines         94432    94432              
  Branches       9830     9830              
============================================
- Hits          31339    31337       -2     
- Misses        60421    60422       +1     
- Partials       2672     2673       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@emeroad emeroad merged commit 9c6f07c into pinpoint-apm:master Jan 19, 2026
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant