Skip to content

[#noissue] Refactor TagUtils to move to util package and deprecate old implementation #13310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
emeroad merged 1 commit into from
Jan 20, 2026
+18 −10
Merged

[#noissue] Refactor TagUtils to move to util package and deprecate old implementation #13310

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...web/src/main/java/com/navercorp/pinpoint/inspector/web/definition/metric/field/Field.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
import com.fasterxml.jackson.annotation.JsonProperty;
import com.navercorp.pinpoint.inspector.web.definition.AggregationFunction;
import com.navercorp.pinpoint.metric.common.model.Tag;
import com.navercorp.pinpoint.metric.common.model.TagUtils;
import com.navercorp.pinpoint.metric.common.util.TagUtils;
import com.navercorp.pinpoint.metric.web.model.basic.metric.group.MatchingRule;

import java.util.List;
Expand Down
2 changes: 1 addition & 1 deletion ...b/src/main/java/com/navercorp/pinpoint/inspector/web/service/DefaultApdexStatService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
import com.navercorp.pinpoint.inspector.web.definition.metric.field.Field;
import com.navercorp.pinpoint.inspector.web.model.InspectorMetricData;
import com.navercorp.pinpoint.inspector.web.model.InspectorMetricValue;
import com.navercorp.pinpoint.metric.common.model.TagUtils;
import com.navercorp.pinpoint.metric.common.util.TagUtils;
import com.navercorp.pinpoint.web.component.ApplicationFactory;
import com.navercorp.pinpoint.web.service.ApdexScoreService;
import com.navercorp.pinpoint.web.vo.Application;
Expand Down
11 changes: 6 additions & 5 deletions ...ule/metric-commons/src/main/java/com/navercorp/pinpoint/metric/common/model/TagUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,18 +17,19 @@

package com.navercorp.pinpoint.metric.common.model;

import java.util.Collections;
import java.util.List;

/**
* @deprecated use {@link com.navercorp.pinpoint.metric.common.util.TagUtils}
*/
@Deprecated
public final class TagUtils {

private TagUtils() {
}

@Deprecated
public static List<Tag> defaultTags(List<Tag> tags) {
if (tags == null) {
return Collections.emptyList();
}
return tags;
return com.navercorp.pinpoint.metric.common.util.TagUtils.defaultTags(tags);
}
}
7 changes: 7 additions & 0 deletions ...dule/metric-commons/src/main/java/com/navercorp/pinpoint/metric/common/util/TagUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,4 +100,11 @@ public static String toTagString(List<Tag> tagList) {
}
return joiner.toString();
}

public static List<Tag> defaultTags(List<Tag> tags) {
if (tags == null) {
return List.of();
}
return tags;
}
}
4 changes: 2 additions & 2 deletions ...int/metric/common/model/TagUtilsTest.java → ...oint/metric/common/util/TagUtilsTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,9 @@
* limitations under the License.
*/

package com.navercorp.pinpoint.metric.common.model;
package com.navercorp.pinpoint.metric.common.util;

import com.navercorp.pinpoint.metric.common.util.TagUtils;
import com.navercorp.pinpoint.metric.common.model.Tag;
import org.junit.jupiter.api.Assertions;
import org.junit.jupiter.api.Test;

Expand Down
2 changes: 1 addition & 1 deletion metric-module/metric/src/main/java/com/navercorp/pinpoint/metric/web/mapping/Field.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
import com.fasterxml.jackson.annotation.JsonCreator;
import com.fasterxml.jackson.annotation.JsonProperty;
import com.navercorp.pinpoint.metric.common.model.Tag;
import com.navercorp.pinpoint.metric.common.model.TagUtils;
import com.navercorp.pinpoint.metric.common.util.TagUtils;
import com.navercorp.pinpoint.metric.web.model.basic.metric.group.MatchingRule;

import java.util.List;
Expand Down
Loading