Skip to content

Conversation

@donghun-cho
Copy link
Contributor

No description provided.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR performs cleanup and refactoring related to the ApplicationMapper and ServiceGroupRowKeyPrefixUtils classes. The changes improve consistency with existing patterns in the codebase and optimize buffer usage.

Changes:

  • Updated ApplicationMapper to return List<Application> instead of single Application, following the same pattern as AgentIdMapper
  • Changed buffer operations from AutomaticBuffer to FixedBuffer with precise size calculations
  • Improved test clarity and coverage in ServiceGroupRowKeyPrefixUtilsTest

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
web/src/main/java/com/navercorp/pinpoint/web/mapper/ApplicationMapper.java Changed from RowMapper<Application> to RowMapper<List<Application>>, improved buffer reading with skip() method
web/src/main/java/com/navercorp/pinpoint/web/dao/hbase/HbaseApplicationDao.java Updated to handle new mapper signature using ListListUtils.toList() for result flattening
commons-server/src/main/java/com/navercorp/pinpoint/common/server/util/ServiceGroupRowKeyPrefixUtils.java Changed from AutomaticBuffer to FixedBuffer with precise size calculation using BytesUtils.computeVar32StringSize()
commons-server/src/test/java/com/navercorp/pinpoint/common/server/util/ServiceGroupRowKeyPrefixUtilsTest.java Refactored test for better clarity with extracted variables and improved assertions

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov
Copy link

codecov bot commented Jan 20, 2026

Codecov Report

❌ Patch coverage is 10.00000% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 33.17%. Comparing base (b1947d0) to head (51f27d0).

Files with missing lines Patch % Lines
...vercorp/pinpoint/web/mapper/ApplicationMapper.java 0.00% 6 Missing ⚠️
...rp/pinpoint/web/dao/hbase/HbaseApplicationDao.java 0.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #13313      +/-   ##
============================================
- Coverage     33.17%   33.17%   -0.01%     
+ Complexity    10973    10972       -1     
============================================
  Files          4060     4060              
  Lines         94232    94235       +3     
  Branches       9808     9808              
============================================
- Hits          31263    31260       -3     
- Misses        60294    60298       +4     
- Partials       2675     2677       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant