[#noissue] Fix bug:Server Map and Service Map read the useStatisticsAgentState experimental option withvalue || true.#14057
Open
hhzscreate wants to merge 1 commit into
Open
Conversation
Server Map and Service Map read the `useStatisticsAgentState` experimental option with`value || true`. JavaScript treats an explicit `false` as falsy, so the expression always evaluates to `true`. Users and server-side configuration therefore cannot disable the feature.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Problem
Server Map and Service Map read the
useStatisticsAgentStateexperimental option withvalue || true. JavaScript treats an explicitfalseas falsy, so the expression always evaluatesto
true. Users and server-side configuration therefore cannot disable the feature.Fix
A shared
resolveUseStatisticsAgentStatefunction now uses the nullish coalescing expressionvalue ?? true:falseremainsfalse;trueremainstrue;nullorundefinedfalls back totrue.This preserves the existing design of enabling the option when the value is absent while respecting
an explicit
falsefrom the user or server configuration.Server Map and Service Map use the same function so their option handling cannot diverge.