Added default alternating colors in the table rows #1545
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would it be better to have this as an optional setting rather that the default? Also, would it be better to define a new color specifically for the alternating rows as currently I'm using the color defined for the border? Thank you for your clarifications! |
|
nice work, could you share the screenshot of what it looks like in dark/non-dark mode? |
|
@sjay8 thanks for putting the PR! could you add it as a user setting? I wonder users may have different preferences. |
|
Just to know- dont we need to consider these combinations are okay for all different user themes (default, dark or lush mode)? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added default alternating colors used existing defining colors following odd- default, even- darker scheme
#1484