Skip to content

Conversation

@raymondtieu
Copy link

@raymondtieu raymondtieu commented Nov 17, 2025

SUMMARY

  • Add react-query dev-tools to improve debugging experience for API calls
  • Modernize the Chart component using TypeScript and re-written as a functional component (TS conversion is already done in superset v5)
  • Add useChartData hook to fetch chart data
    • uses legacy global polling for async queries

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Example usage before with clean cache

Screen.Recording.2025-11-28.at.2.54.58.PM.mov

Example usage after with clean cache

Screen.Recording.2025-11-28.at.4.13.44.PM.mov

TESTING INSTRUCTIONS

  • Tested with superset's sample data
    • verified synchronous requests render charts
  • Tested with dev environment
    • verified synchronous requests render charts
    • verified async requests use polling
  • Hard to measure actual performance improvements without a production implementation of the workers for the async requests

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@raymondtieu raymondtieu force-pushed the dashboard-page-optimization-tanstack branch from 840afbd to 7741a9a Compare November 28, 2025 20:09
@raymondtieu raymondtieu marked this pull request as ready for review November 28, 2025 20:26
@raymondtieu raymondtieu marked this pull request as draft November 28, 2025 20:38
@raymondtieu raymondtieu marked this pull request as ready for review November 28, 2025 21:15
@raymondtieu raymondtieu changed the base branch from pinterest-release-4.1.1 to chart-load-react-query November 28, 2025 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant