forked from apache/superset
-
Notifications
You must be signed in to change notification settings - Fork 9
Load dashboard charts using react-query #120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
raymondtieu
wants to merge
28
commits into
pinterest:chart-load-react-query
Choose a base branch
from
raymondtieu:dashboard-page-optimization-tanstack
base: chart-load-react-query
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Load dashboard charts using react-query #120
raymondtieu
wants to merge
28
commits into
pinterest:chart-load-react-query
from
raymondtieu:dashboard-page-optimization-tanstack
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
840afbd to
7741a9a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Chartcomponent using TypeScript and re-written as a functional component (TS conversion is already done in superset v5)BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Example usage before with clean cache
Screen.Recording.2025-11-28.at.2.54.58.PM.mov
Example usage after with clean cache
Screen.Recording.2025-11-28.at.4.13.44.PM.mov
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION