Skip to content

Conversation

@kgopal492
Copy link
Collaborator

SUMMARY

  • Chart key previously wasn't passed to refreshAnnotationData function, so it is determined by taking the key of the first chart in list of charts in application state
  • when chart is loaded from a dashboard context, there are multiple charts in the application state, so the chart key can be incorrectly generated, causing an error & preventing users to add annotations to their charts
  • This change fixes the bug by passing the correct chart key to the refreshAnnotationData function

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

Tested by adding annotations to a chart loaded from dashboard.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link

@raymondtieu raymondtieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kgopal492 kgopal492 merged commit 5558495 into pinterest:pinterest-release-5.0.0 Jan 6, 2026
21 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants