Skip to content

Upgrade golangci-lint, more linters#690

Merged
JoTurk merged 1 commit intomasterfrom
impr/lint
Jan 27, 2025
Merged

Upgrade golangci-lint, more linters#690
JoTurk merged 1 commit intomasterfrom
impr/lint

Conversation

@JoTurk
Copy link
Member

@JoTurk JoTurk commented Jan 24, 2025

Description

Introduces new linters, upgrade golangci-lint to version (v1.63.4)

Reference issue

pion/.goassets#220

@JoTurk JoTurk mentioned this pull request Jan 24, 2025
20 tasks
@codecov
Copy link

codecov bot commented Jan 24, 2025

Codecov Report

Attention: Patch coverage is 88.37209% with 75 lines in your changes missing coverage. Please review.

Project coverage is 78.75%. Comparing base (1c0df61) to head (8eb9a91).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
conn.go 80.46% 16 Missing and 9 partials ⚠️
crypto.go 64.70% 0 Missing and 6 partials ⚠️
pkg/crypto/ccm/ccm.go 57.14% 4 Missing and 2 partials ⚠️
pkg/crypto/ciphersuite/cbc.go 79.31% 1 Missing and 5 partials ⚠️
handshaker.go 86.20% 2 Missing and 2 partials ⚠️
pkg/crypto/hash/hash.go 33.33% 4 Missing ⚠️
flight3handler.go 92.50% 0 Missing and 3 partials ⚠️
flight4handler.go 93.02% 0 Missing and 3 partials ⚠️
pkg/crypto/ciphersuite/ccm.go 75.00% 2 Missing and 1 partial ⚠️
flight5handler.go 94.59% 0 Missing and 2 partials ⚠️
... and 10 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #690      +/-   ##
==========================================
+ Coverage   78.31%   78.75%   +0.43%     
==========================================
  Files         101      101              
  Lines        6567     6810     +243     
==========================================
+ Hits         5143     5363     +220     
- Misses       1054     1077      +23     
  Partials      370      370              
Flag Coverage Δ
go 78.77% <88.37%> (+0.43%) ⬆️
wasm 63.79% <73.79%> (+0.60%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JoTurk JoTurk requested a review from daenney January 24, 2025 17:24
@JoTurk JoTurk force-pushed the impr/lint branch 2 times, most recently from 1499325 to 01b3f4c Compare January 27, 2025 16:14
Introduces new linters, upgrade golangci-lint to version (v1.63.4)
@JoTurk JoTurk merged commit 8eb9a91 into master Jan 27, 2025
16 checks passed
@JoTurk JoTurk deleted the impr/lint branch January 27, 2025 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants