Skip to content

Refactor cfg.onFlightState, use atomic bool#709

Merged
JoTurk merged 1 commit intomasterfrom
fix-set-handshake-data-race
May 4, 2025
Merged

Refactor cfg.onFlightState, use atomic bool#709
JoTurk merged 1 commit intomasterfrom
fix-set-handshake-data-race

Conversation

@JoTurk
Copy link
Copy Markdown
Member

@JoTurk JoTurk commented May 4, 2025

Description

Simplify handshakeCompletedSuccessfully, use atomic.Bool and use CompareAndSwap in setHandshakeCompletedSuccessfully to avoid potential data race!

Reference issue

Fixes #667

@codecov
Copy link
Copy Markdown

codecov bot commented May 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.63%. Comparing base (f5e908f) to head (806ff2f).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #709      +/-   ##
==========================================
+ Coverage   78.58%   78.63%   +0.04%     
==========================================
  Files         101      101              
  Lines        6831     6828       -3     
==========================================
+ Hits         5368     5369       +1     
+ Misses       1089     1085       -4     
  Partials      374      374              
Flag Coverage Δ
go 78.65% <100.00%> (+0.04%) ⬆️
wasm 57.11% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@JoTurk JoTurk force-pushed the fix-set-handshake-data-race branch 3 times, most recently from c5e8846 to 806ff2f Compare May 4, 2025 10:52
@JoTurk JoTurk merged commit 806ff2f into master May 4, 2025
16 checks passed
@JoTurk JoTurk deleted the fix-set-handshake-data-race branch May 4, 2025 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ensuring Goroutine Safety in DTLS Connection Handshake Completion

1 participant