Open
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #805 +/- ##
==========================================
- Coverage 82.52% 82.50% -0.02%
==========================================
Files 121 121
Lines 6868 6906 +38
==========================================
+ Hits 5668 5698 +30
- Misses 786 800 +14
+ Partials 414 408 -6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
110dedb to
3d9e777
Compare
Member
Author
|
The fuzzing discovered multiple discreprencies in how we handle declared length and trailing bytes. Multiple extension parsers does not verify the declared length or extra trailing bytes in the extension data, this PR also fixes that. |
Member
Author
|
|
3d9e777 to
22b7c64
Compare
af4b30d to
9805700
Compare
Member
|
Sorry I lost track of this, I'll try to finish my review tonight. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to add fuzz testing of the umarshal functions of all extensions.