Skip to content

Optimize handshake memory usage#815

Open
noboruma wants to merge 1 commit intopion:masterfrom
noboruma:master
Open

Optimize handshake memory usage#815
noboruma wants to merge 1 commit intopion:masterfrom
noboruma:master

Conversation

@noboruma
Copy link
Contributor

Description

Avoid unnecessary copy of packet header data when pushing to cache.
Avoid unnecessary copy & reallocation inside message certificate marshalling.

@codecov
Copy link

codecov bot commented Mar 13, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.54%. Comparing base (956d41d) to head (6890ea7).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #815      +/-   ##
==========================================
+ Coverage   82.53%   82.54%   +0.01%     
==========================================
  Files         120      120              
  Lines        6802     6807       +5     
==========================================
+ Hits         5614     5619       +5     
  Misses        778      778              
  Partials      410      410              
Flag Coverage Δ
go 82.54% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@theodorsm theodorsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM. Since we don't export handshakeCache, removing the copying in push should be fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants