#742 net: pass ipv6 zone param to net.ListenUDP #744
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
N1cOs
force-pushed
the
fix/use-ipv6-zone-for-link-local-addrs
branch
from
7d1bdf9 to
d3aef08
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #744 +/- ##
==========================================
+ Coverage 78.61% 78.63% +0.02%
==========================================
Files 41 41
Lines 4764 4769 +5
==========================================
+ Hits 3745 3750 +5
Misses 785 785
Partials 234 234
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
listenUDPInPortRange wasn't passing the Zone and would always fail to bind. This would cause high CPU usage as every port in the range would be attempted and fail. Fixes pion#742
Sean-Der
force-pushed
the
fix/use-ipv6-zone-for-link-local-addrs
branch
from
d3aef08 to
566058b
Compare
Sean-Der
approved these changes
Nov 26, 2024
|
Fantastic! Thank you for fixing this @N1cOs |
|
@N1cOs Can you try pion/webrtc/[email protected] now? |
|
I will check in a few days, but on v4.0.2 ignoring link-local addresses definitely fixes the high CPU consumption on connection initiation |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Pass ipv6 zone param to
net.ListenUDP. Also checked that it's specified in all other calls ofnet.ListenUDP. Tested it locally with ipv6 link-local and global unicast addresses.However, should I add a unit test for that @Sean-Der? I could add it in the gather_test.go, but it would be host specific and require an assigned ipv6 address.
Also don't forget to backport to v3, because ipv6 link-local addresses appeared in v3.
Reference issue
Fixes #742