Add Req/Res count/time to candidate stats #763
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #763 +/- ##
==========================================
+ Coverage 78.66% 78.77% +0.10%
==========================================
Files 41 41
Lines 5367 5437 +70
==========================================
+ Hits 4222 4283 +61
- Misses 915 923 +8
- Partials 230 231 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
cnderrauber
force-pushed
the
pair_stats
branch
4 times, most recently
from
a63eb7f to
c645c14
Compare
These details will provide information for connectivity issue.
cnderrauber
force-pushed
the
pair_stats
branch
from
c645c14 to
d1e43a7
Compare
|
|
||
| // UpdateResponseSent increments the number of responses sent. | ||
| func (p *CandidatePair) UpdateResponseSent() { | ||
| atomic.AddUint64(&p.responsesSent, 1) |
There was a problem hiding this comment.
Is there any value to adding first/last response sent time?
With this PR, we have
- first/last time of request sent
- first/last time of request received
- first/last time of response received
wondering if there is more to learn by recording first/last time of response sent?
There was a problem hiding this comment.
I had it but deleted at last since the agent always send response when request is received, so the timpstamp is useless (the responseSent has same issue too but it is in the specification https://www.w3.org/TR/webrtc-stats/#dom-rtcicecandidatepairstats-responsessent so I keep it).
There was a problem hiding this comment.
got it, thank you @cnderrauber
These details will provide information for understanding
connectivity issue.