Skip to content

Conversation

@adeithe
Copy link
Member

@adeithe adeithe commented Oct 5, 2025

Description

Defaults relay-only agent candidate types acceptance wait to zero

Reference issue

Fixes #324

@codecov
Copy link

codecov bot commented Oct 5, 2025

Codecov Report

❌ Patch coverage is 80.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.40%. Comparing base (3897c30) to head (ed14a44).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
agent_config.go 80.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #819      +/-   ##
==========================================
- Coverage   86.53%   86.40%   -0.13%     
==========================================
  Files          43       43              
  Lines        5680     5687       +7     
==========================================
- Hits         4915     4914       -1     
- Misses        604      610       +6     
- Partials      161      163       +2     
Flag Coverage Δ
go 86.30% <80.00%> (-0.13%) ⬇️
wasm 33.89% <50.00%> (+0.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@adeithe adeithe force-pushed the fix/relay-only-canidate-delay branch from e0d61ef to f1d979e Compare October 5, 2025 03:29
Copy link
Member

@JoeTurki JoeTurki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, please squash all the commits into a single one and you should be able to merge it, thank you :)

@JoeTurki JoeTurki force-pushed the fix/relay-only-canidate-delay branch from f1d979e to ed14a44 Compare October 5, 2025 08:49
@JoeTurki JoeTurki merged commit ed14a44 into master Oct 5, 2025
23 of 24 checks passed
@JoeTurki JoeTurki deleted the fix/relay-only-canidate-delay branch October 5, 2025 08:54
@JoeTurki
Copy link
Member

JoeTurki commented Oct 5, 2025

@adeithe Thank you so much for fixing this, looking forward for your incoming contributions :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

Skip the two-second delay when ICETransportPolicy=ICETransportPolicyRelay

4 participants