-
Couldn't load subscription status.
- Fork 182
Add automatic renomination #822
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is
❌ Your patch status has failed because the patch coverage (66.12%) is below the target coverage (70.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## master #822 +/- ##
==========================================
- Coverage 87.61% 86.82% -0.79%
==========================================
Files 43 43
Lines 4537 4706 +169
==========================================
+ Hits 3975 4086 +111
- Misses 392 444 +52
- Partials 170 176 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
c546566 to
f226eba
Compare
|
works great on nixos :) |
0250d40 to
0534d2b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is awesome. I had a lot of fun playing with it and testing it everywhere. I tried the controlling-agent example on Linux, macOS, and Windows (was so tricky). I also read through the libwebrtc implementation.
this is really cool.
agent_config.go
Outdated
| // setup but will have no effect on connectivity. | ||
| AutomaticRenomination bool | ||
|
|
||
| // RenominationInterval is the minimum time to wait after connection before considering | ||
| // automatic renomination. This prevents excessive renominations during initial connection setup. | ||
| // If nil, defaults to 3 seconds (matching libwebrtc behavior). | ||
| RenominationInterval *time.Duration |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we're dropping this config in the next major release, maybe let's stick with the options. If users want the new feature, they can move to the new API.
What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense to me! Removed.
|
|
||
| ## How It Works | ||
|
|
||
| The automatic renomination feature evaluates candidate pairs based on: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will be cool if we provide a docker image with this example, I made a scuffed one while i was testing, can clean and commit it :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah that would be helpful! Can you push yours?
Definitely the hardest part of testing this is the networking setup.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah that would be helpful! Can you push yours?
cool, I'll make a PR.
3e2bd80 to
a7f7c50
Compare
a7f7c50 to
010a95a
Compare
Description
Adds automatic renomination as an ICE agent option which allows the ICE agent to switch to the best available link. The logic for this was scoped out of libwebrtc, which also has a 3s polling interval and continuously pings candidates.
The example is probably the best way to see how this feature works. It establishes two virtual links and then you can see it switch between them based on the RTT, which is controlled by the user.
Reference issue
Fixes #...