(1/3) Add NV12 frame format support for windows#682
Open
hexbabe wants to merge 5 commits intopion:masterfrom
Open
(1/3) Add NV12 frame format support for windows#682hexbabe wants to merge 5 commits intopion:masterfrom
hexbabe wants to merge 5 commits intopion:masterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #682 +/- ##
=======================================
Coverage 42.13% 42.13%
=======================================
Files 86 86
Lines 5186 5186
=======================================
Hits 2185 2185
Misses 2839 2839
Partials 162 162 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…tion to FORMAT_VideoInfo. This change allows for better compatibility with various video formats by correctly retrieving width, height, and compression details from both format types (NV12 and YUY2)
hexbabe
force-pushed
the
add-nv12-support-windows
branch
from
07f7683 to
d52fa53
Compare
hexbabe
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Implements the most used webcam frame format, NV12, alongside preserving existing YUY2 support for windows.
Manual Testing
Fixes Michael's windows machine integrated webcam via d52fa53. It is now able to be detected and streamed from.
Reference issue
Partially addresses #95
Inspired by the inactive PR: #657
Note
I agree with the issue that we should eventually migrate to mediafoundation, but these PRs are the least we can do to get DirectShow implementation working as for now