Skip to content

Conversation

@cppcoffee
Copy link
Member

@cppcoffee cppcoffee commented Aug 27, 2025

use tls.Config.Clone() to avoid copying lock warning

Fixed #235

Signed-off-by: Xiaobo Liu <[email protected]>
@codecov
Copy link

codecov bot commented Aug 27, 2025

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 64.96%. Comparing base (5b4f5bc) to head (0d6194b).

Files with missing lines Patch % Lines
client.go 0.00% 2 Missing ⚠️

❌ Your patch status has failed because the patch coverage (0.00%) is below the target coverage (70.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #240   +/-   ##
=======================================
  Coverage   64.96%   64.96%           
=======================================
  Files          27       27           
  Lines        2637     2637           
=======================================
  Hits         1713     1713           
  Misses        913      913           
  Partials       11       11           
Flag Coverage Δ
go 64.96% <0.00%> (ø)
wasm 41.48% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@JoeTurki JoeTurki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, sadly this doesn't fix #235 we still hold TLSConfig by value.

@cppcoffee
Copy link
Member Author

cppcoffee commented Aug 27, 2025

I got it.

@cppcoffee cppcoffee closed this Aug 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

stun.DialConfig{} requires a tls.Config instead of *tls.Config

2 participants