Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #559 +/- ##
==========================================
+ Coverage 81.84% 81.88% +0.03%
==========================================
Files 46 46
Lines 3195 3196 +1
==========================================
+ Hits 2615 2617 +2
+ Misses 379 378 -1
Partials 201 201
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
sirzooro
force-pushed
the
bind_error_log
branch
2 times, most recently
from
2076bf4 to
46f91d1
Compare
Member
|
please ignore all the unrelated lint errors, we're doing a lint upgrade #558 we can bypass the CI to merge the error fix in the meantime. |
Include received error code in returned error
sirzooro
force-pushed
the
bind_error_log
branch
from
46f91d1 to
6949da6
Compare
Contributor
Author
Done, removed unrelated changes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Include received error code in returned error. Now TURN client logs "turnc warning: Failed to bind bind(): unexpected response type ChannelBind response type" without details what really happened.