Make sign-in SSO-only and add a theme switcher - #12
Merged
Conversation
The sign-in card was sized by the email/password form, so removing those fields on its own would have left a heading floating in an empty card. Resize the card to its content and promote the SSO button to the page's primary action, inheriting the ink-filled treatment the submit button used to own. - Replace LoginFormPanel, LoginSubmitButton, LoginField and useLoginForm with SignInPanel, SsoSignInButton and useSsoSignIn - Drop the now-dead login(email, password) from useAuth - Add ThemeToggle, a compact swatch picker for pages with no account menu, below the brand copy - Move the action button's hardcoded Bloom colors (#3b3022 hover, warm rgba shadows) onto themed --finlens-action-* vars, so the Slate theme no longer renders a warm-brown hover on a cool page
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The sign-in card was sized by the email/password form, so removing those fields on its own would have left a heading floating in an empty card. Resize the card to its content and promote the SSO button to the page's primary action, inheriting the ink-filled treatment the submit button used to own.