Switch web to published @pior-labs/design-system@1.0.0 - #4
Closed
iPior wants to merge 1 commit into
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
@pior-labs/design-system@1.0.0release.@pior-labsscope resolves from GitHub Packages to allow fetching the published package during installs.Description
@ipior/custom-tailwind-shadcn-themeswith@pior-labs/design-systemat version1.0.0inpackages/web/package.json.packages/web/src/app.cssto import@pior-labs/design-system/styles.cssand@pior-labs/design-system/effects.cssinstead of the previous package.packages/web/src/hooks/useTheme.tsxto importThemeProvider, types and utilities from@pior-labs/design-system..npmrcentry to point the@pior-labsscope at GitHub Packages (@pior-labs:registry=https://npm.pkg.github.com).Testing
pnpm --filter @finlens/web install --lockfile-only, which failed due to registry authorization errors (npm returned403 Forbiddenfor some packages), so lockfile update could not be validated in this environment.pnpm --filter @finlens/web typecheck, which failed because@pior-labs/design-systemcould not be fetched/installed here and TypeScript could not resolve the module.pnpm --filter @finlens/web install --lockfile-only --offlinewas attempted and failed due to missing offline metadata for dependencies, so no successful install verification was possible.Codex Task