Skip to content

Add and improve issue templates (Resolves #65)#266

Open
zicaiw625 wants to merge 1 commit into
piotrwitek:masterfrom
zicaiw625:master
Open

Add and improve issue templates (Resolves #65)#266
zicaiw625 wants to merge 1 commit into
piotrwitek:masterfrom
zicaiw625:master

Conversation

@zicaiw625
Copy link
Copy Markdown

Description

This PR adds and improves issue templates as requested in issue #65.

Changes Made:

  1. Improved bug report template ():

    • Added clearer instructions for using CodeSandbox
    • Made the CodeSandbox link more prominent with bold text
    • Added step-by-step guidance for bug reproduction
  2. Enhanced question template ():

    • Renamed from 'custom' to 'question' template
    • Added detailed guidelines for when to use issue tracker vs Spectrum chat
    • Added structured sections for questions: goals, attempts, code examples, environment
  3. Added examples folder ():

    • Created examples folder with documentation
    • Added link to pre-configured CodeSandbox starter
    • Provided guidance for bug reporting process
    • Listed available examples in the repository

Requirements Met (from issue #65):

  • ✅ Bug report template (improved)
  • ✅ Feature request template (already existed)
  • ✅ Question template (improved)
  • ✅ PR template (already existed)
  • ✅ CodeSandbox starter documentation in examples/ folder
  • ✅ Link to online CodeSandbox editor in bug report template

Testing:

All templates are functional and follow GitHub's issue template format. The CodeSandbox link points to the existing codesandbox/ folder in the repository.

Resolves #65

- Improved bug report template with clearer CodeSandbox instructions
- Enhanced question template with detailed guidelines
- Added examples/README.md with starter template documentation
- All required templates are now in place: bug report, feature request, question, and PR template

Resolves piotrwitek#65
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request improves the project's documentation and issue reporting process by updating the bug report and question templates and adding a README to the examples directory. The changes provide clearer instructions for using CodeSandbox and structure the question template for more detailed submissions. Feedback suggests renaming the question template file for consistency, adding version placeholders to the environment fields, and including a trailing newline in the new README file.

@@ -1,9 +1,37 @@
---
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The pull request description mentions that this template was renamed from 'custom' to 'question', but the file path remains .github/ISSUE_TEMPLATE/custom.md. Renaming the file to question.md would ensure consistency with the template's name and the PR's stated changes.

Comment on lines +34 to +37
- TypeScript Version:
- typesafe-actions Version:
- React/Redux Version (if applicable):
- Node Version:
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Adding placeholders (e.g., X.X.X) to the environment fields would make the template consistent with the bug report template and provide clearer guidance to users on what information is expected.

Suggested change
- TypeScript Version:
- typesafe-actions Version:
- React/Redux Version (if applicable):
- Node Version:
- TypeScript Version: X.X.X
- typesafe-actions Version: X.X.X
- React/Redux Version (if applicable): X.X.X
- Node Version: X.X.X

Comment thread examples/README.md

- **Todo App**: Complete example in the `codesandbox/` folder
- **Basic Usage**: Check the main README.md for code examples
- **API Examples**: See the test files in `src/` for usage patterns No newline at end of file
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The file is missing a trailing newline. It is a standard practice to include a newline at the end of text files to ensure compatibility with various tools and to avoid warnings in diffs.

Suggested change
- **API Examples**: See the test files in `src/` for usage patterns
- **API Examples**: See the test files in `src/` for usage patterns

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add issue templates

1 participant