Skip to content

Document Services type for epics#268

Open
apples-kksk wants to merge 2 commits into
piotrwitek:masterfrom
apples-kksk:explain-services-type
Open

Document Services type for epics#268
apples-kksk wants to merge 2 commits into
piotrwitek:masterfrom
apples-kksk:explain-services-type

Conversation

@apples-kksk
Copy link
Copy Markdown

@apples-kksk apples-kksk commented May 9, 2026

Summary

  • explain what the Services type represents in redux-observable epic signatures
  • show how to derive Services from an injected dependencies object
  • add examples for wiring services into createEpicMiddleware and mocking them in tests

Fixes #103

Verification

  • git diff --check

IssueHunt Summary

Referenced issues

This pull request has been submitted to:


Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a new section to the README documentation explaining the Services type for redux-observable epics, including examples for service definition, middleware integration, and unit testing. A review comment identified a type mismatch in the documentation's example code where a string was passed to an action creator expecting an Error object, and a correction was suggested to maintain type safety.

Comment thread README.md Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

I would like an explanation of the Service type in epics.

2 participants