Fix enableMic: false still activating microphone device on iOS#25
Draft
Fix enableMic: false still activating microphone device on iOS#25
Conversation
When enableMic: false is set, initDevices() was calling startCamera() without forwarding the startAudioOff/startVideoOff options. This caused the mic device to activate on iOS even when disabled. Now these options from _dailyFactoryOptions are passed through, consistent with how DailyMediaManager handles this in the SmallWebRTC transport. Co-authored-by: jamsea <614910+jamsea@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix microphone activation issue on iOS with enableMic: false
Fix enableMic: false still activating microphone device on iOS
Mar 3, 2026
Contributor
|
@copilot I believe we need to add this when creating the callObject (function should look something like createCallObject) |
…ff/startVideoOff Defers Daily.createCallObject() from the constructor to initialize(), where enableMic/enableCam have been processed into startAudioOff/startVideoOff. This ensures the call object is created with the correct audio/video off settings from the start, preventing iOS from activating the mic hardware. Co-authored-by: jamsea <614910+jamsea@users.noreply.github.com>
Author
Moved |
|
I tried this and it prevents the Pipecat SDK from being initialized |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
enableMic: falseis passed toPipecatClient, the microphone device still activates on iOS becauseDaily.createCallObject()was called in the constructor beforeinitialize()had a chance to setstartAudioOff/startVideoOfffromenableMic/enableCam. Additionally,initDevices()calledstartCamera()without forwarding these options.Daily.createCallObject()from the constructor toinitialize(), so the call object is created afterenableMic/enableCamhave been processed intostartAudioOff/startVideoOffstartAudioOffandstartVideoOfffrom_dailyFactoryOptionsthrough tostartCamera()ininitDevices(), matching howDailyMediaManageralready handles this in the SmallWebRTC transportOriginal prompt
🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.