Use explicit Daily room config with SIP provider for Twilio bots#197
Open
Use explicit Daily room config with SIP provider for Twilio bots#197
Conversation
- dial-in: Use DailyRoomProperties with geo, expiry, and SIP params instead of simple configure() call. Pass sip_provider and to_phone through to bot for future multi-region credential selection. - dial-out: Set explicit room properties (geo, enable_dialout, expiry). Add provider field to DialoutSettings so it can be passed via curl. Add dialout event handlers for better observability. - Add .env.example files to both Twilio bot directories. - Update dial-in README examples to include to_phone field.
markbackman
reviewed
Mar 11, 2026
Contributor
markbackman
left a comment
markbackman
left a comment
There was a problem hiding this comment.
Just a few comments. The biggest being trying to absorb the change into configure() if possible to make it easier to use SIP.
Both directories already have env.example (without dot prefix).
4 tasks
markbackman
approved these changes
Mar 12, 2026
Contributor
markbackman
left a comment
markbackman
left a comment
There was a problem hiding this comment.
LGTM. Let's merge once 0.0.106 is released.
markbackman
reviewed
Mar 12, 2026
markbackman
reviewed
Mar 12, 2026
- Rename titles to show the full call path - Add ASCII flow diagrams - Explain provider="daily" and why Twilio is involved - Link to daily-pstn-* examples for Daily-owned numbers - Add note about dynamic callerId via SIP URI overloading - Add note about Daily Provider static IP advantage for ACLs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
configure(session, sip_caller_phone=...)with explicitDailyRoomPropertiesandDailyRoomSipParamsfor full control over room configuration (geo, expiry, SIP provider). Passto_phonethrough to bot for future multi-region Twilio credential selection.geo,enable_dialout, expiry). Addproviderfield toDialoutSettingsso it can be passed via curl instart_dialout. Add dialout event handlers (on_dialout_connected,on_dialout_stopped,on_dialout_warning) for better observability..env.examplefiles to both Twilio bot directories.to_phonefield.Test plan
curl -X POST http://localhost:8080/dialoutwithprovider: "daily", verify bot dials out and conversesus-east-1geo with correct expiry (600s)providerfield (backward compatibility)