feat: add unit tests and fix memory leak#429
Open
missshang-hero wants to merge 1 commit intopipipi-pikachu:masterfrom
Open
feat: add unit tests and fix memory leak#429missshang-hero wants to merge 1 commit intopipipi-pikachu:masterfrom
missshang-hero wants to merge 1 commit intopipipi-pikachu:masterfrom
Conversation
missshang-hero
commented
Mar 11, 2026
missshang-hero
commented
- Fix memory leak in getImageSize() when image fails to load
- Add vitest configuration for unit testing
- Add unit tests for element.ts (13 tests)
- Add unit tests for image.ts (6 tests)
- Update package.json with test scripts and dependencies
- Fix memory leak in getImageSize() when image fails to load - Add vitest configuration for unit testing - Add unit tests for element.ts (13 tests) - Add unit tests for image.ts (6 tests) - Update package.json with test scripts and dependencies
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.